Skip to content

Commit dc50dd3

Browse files
Sudhir Mitharwalmrmckeb
authored andcommitted
Allow title to be set when importing SVGs (#7118)
1 parent 7c0dfef commit dc50dd3

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: Bug report
33
about: Create a report to help us improve
4-
labels: "issue: bug"
4+
labels: 'issue: bug'
55
---
66

77
<!--
@@ -59,7 +59,6 @@ labels: "issue: bug"
5959

6060
(Write your answer here.)
6161

62-
6362
### Which terms did you search for in User Guide?
6463

6564
<!--
@@ -79,7 +78,6 @@ labels: "issue: bug"
7978

8079
(Write your answer here if relevant.)
8180

82-
8381
### Environment
8482

8583
<!--
@@ -96,7 +94,6 @@ labels: "issue: bug"
9694

9795
(paste the output of the command here.)
9896

99-
10097
### Steps to reproduce
10198

10299
<!--
@@ -106,10 +103,9 @@ labels: "issue: bug"
106103

107104
(Write your steps here:)
108105

109-
1.
110-
2.
111-
3.
112-
106+
1.
107+
2.
108+
3.
113109

114110
### Expected behavior
115111

@@ -121,7 +117,6 @@ labels: "issue: bug"
121117

122118
(Write what you thought would happen.)
123119

124-
125120
### Actual behavior
126121

127122
<!--
@@ -132,7 +127,6 @@ labels: "issue: bug"
132127

133128
(Write what happened. Please add screenshots!)
134129

135-
136130
### Reproducible demo
137131

138132
<!--
@@ -153,7 +147,6 @@ labels: "issue: bug"
153147

154148
(Paste the link to an example project and exact instructions to reproduce the issue.)
155149

156-
157150
<!--
158151
What happens if you skip this step?
159152

.github/ISSUE_TEMPLATE/proposal.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: Proposal
33
about: Suggest an idea for improving Create React App
4-
labels: "issue: proposal"
4+
labels: 'issue: proposal'
55
---
66

77
### Is your proposal related to a problem?
@@ -32,7 +32,7 @@ labels: "issue: proposal"
3232
### Additional context
3333

3434
<!--
35-
Is there anything else you can add about the proposal?
35+
Is there anything else you can add about the proposal?
3636
You might want to link to related issues here, if you haven't already.
3737
-->
3838

packages/react-scripts/config/webpack.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,8 @@ module.exports = function(webpackEnv) {
388388
{
389389
loaderMap: {
390390
svg: {
391-
ReactComponent: '@svgr/webpack?-svgo,+ref![path]',
391+
ReactComponent:
392+
'@svgr/webpack?-svgo,+titleProp,+ref![path]',
392393
},
393394
},
394395
},

packages/react-scripts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"types": "./lib/react-app.d.ts",
3030
"dependencies": {
3131
"@babel/core": "7.4.3",
32-
"@svgr/webpack": "4.2.0",
32+
"@svgr/webpack": "4.3.1",
3333
"@typescript-eslint/eslint-plugin": "1.10.2",
3434
"@typescript-eslint/parser": "1.10.2",
3535
"babel-eslint": "10.0.1",

0 commit comments

Comments
 (0)