Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[APPLE][WIP] XCFrameworks Support #2593

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Lcsmarcal
Copy link
Contributor

@Lcsmarcal Lcsmarcal commented Mar 3, 2021

Related to (#2594)

@Lcsmarcal Lcsmarcal changed the title [WIP] XCFrameworks Support [APPLE][WIP] XCFrameworks Support Mar 3, 2021
@rajyengi
Copy link
Contributor

Sorry for letting this stagnate @Lcsmarcal, do you mind rebasing? The circleci configs got updated to fix these jdk install failures that the circle ci jobs on your PR are failing on.

@Lcsmarcal
Copy link
Contributor Author

Lcsmarcal commented May 13, 2021

Done @rajyengi. This PR is a work in progress, it can improved with buck developers (or the community itself) code review.

Edit: as a WIP, I didn't fix/write the integration tests. I can fix it if you want :)

@Lcsmarcal Lcsmarcal marked this pull request as ready for review May 13, 2021 14:04
@KapJI
Copy link
Member

KapJI commented Jun 1, 2021

Yeah, I'd be great to have some tests for this new feature.

And that RustBinaryIntegrationTest is very flaky, if you can fix it (in a separate PR), I'll really appreciate that 🙂

@KapJI
Copy link
Member

KapJI commented Aug 27, 2021

@Lcsmarcal is it still WIP?

@Thomvis
Copy link

Thomvis commented Apr 29, 2022

It would be great to get this merged. Anything I can help make that happen?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants