'unload' event is deprecated

[bhousel]

We use this event to release the localStorage mutex, but it seems like browsers are dropping support for it.

Rapid/modules/core/EditSystem.js

Line 145 in 695d7f2

window.addEventListener('unload', () => this._mutex.unlock());

more info here
https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event
https://chromestatus.com/feature/5579556305502208

[eneerhut]

Is the purpose of this event to help us understand when someone leaves the site @bhousel?

[bhousel]

Is the purpose of this event to help us understand when someone leaves the site @bhousel?

Yes - the "mutex" mentioned above is a trick that means that if you have multiple Rapid tabs open then only one of them will be allowed to backup the user's edits. When you close the tab, it releases that lock.

The whole thing is kind of messy and we should probably rethink how saving user's backups should work.

[eneerhut]

Thanks for clarifying. Sounds like pretty core functionality to avoid failure states and edit conflicts.