-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IText): some RTL selection issues #7864
base: master
Are you sure you want to change the base?
Conversation
and a bit of tidying up
and a bit of tidying up
* feat(): filter options * visual test
and a bit of tidying up
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Code Coverage Summary
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@ShaMan123 hi there, I'm working with RTL direction in textBox, In version 4.6 it has problems with selection when text is aligned to center or right. |
This PR isn't merged so it is obvious your fiddle is broken. |
oh, thanks. |
No |
|
I wish I could help but I can't at the moment. |
@ShaMan123 Many thanks for the RTL update. I successfully integrated fabric-rtl@5.1.0 into my project, and it's working well. However, I encountered some issues after downgrading from fabric@5.3.0, which I was previously using. I wonder if you have a similar implementation for fabric@5.3.0 that can be used? TY |
I plan to migrate it to v6. |
I still encountered text selection problems when direction is "rtl" and textAlign is "right", that I couldn't select any part of the text, and when I click in the middle of the text the cursor is always at the right. My version of fabricjs is "^6.0.0-beta19", and I wonder if this bug is solved or not as all the rtl issues and discussions I found here on github still confuse me a lot😥 @ShaMan123 Seems the fix is still not merged? |
setSelectionRange
to align with html standard andselectionDirection
_selectionDirection
, didn't remove it yet. It has no affect but I want you to look at it before I remove it to see I am not missing out on anything.selectionDirection
is now updated by the textarea on_updateTextarea
but that might not be the right way to do it.