Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework SVG code to have clipPath friendly transformations #5284

Merged
merged 18 commits into from
Oct 7, 2018
Merged

Rework SVG code to have clipPath friendly transformations #5284

merged 18 commits into from
Oct 7, 2018

Conversation

asturur
Copy link
Member

@asturur asturur commented Sep 30, 2018 •
edited
Loading

Wrap every object in a group with transform, so that clipPath can be embedded and auto transformed.

Improve code reuse for toSVG export

close #5264

@asturur
Copy link
Member Author

asturur commented Oct 7, 2018

I may have broken some SVG exports, i ll add more tests before publishin 2.4.2

@asturur asturur merged commit a7ff2bf into master Oct 7, 2018
@asturur asturur mentioned this pull request Oct 14, 2018
Merged
@asturur asturur deleted the tweak-toSVG branch October 29, 2018 20:58
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
@asturur
Rework SVG code to have clipPath friendly transformations (fabricjs#5284
f2944a3 
)

* so far i think i broke everything

* halp super hard

* this is what i wanted

* fixed error

* some fixes

* svg-working

* less code

* fixed shadow for text and groups

* fixed tests

* one file test more

* fixed lint

* works

* ok more tests

* remove a lint issue

* removed unused method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clipPath toSVG bug
1 participant
@asturur