deploy command is too restrictive

[gorkem]

deploy command is too restrictive for multi-container scenarios. deploy requires certain resources to exist on the resource yaml but in the case of multi-container applications there can be multiple files that are applied. For instance if application requires 2 DeploymentConfigs one for a database and one for the application to be build, it is common (and perhaps mandatory) to separate the deployment configs to separate files and deploy them individually. An application can easily not have Service and Route.

[hrishin]

hi @gorkem

. An application can easily not have Service and Route.

This is what you mean to say https://github.com/fabric8io/osio-pipeline/blob/master/vars/deploy.groovy#L46, just porcess all the resources and apply them?

one for the application to be build, it is common (and perhaps mandatory) to separate the deployment configs to separate files and deploy them individually

This is achiveable with loadResources API.

[gorkem]

The issue is the required fields [1]. loadResources is fine but it does not apply the resources to the namespace. One needs to use deploy for that and deploy is restricted. If you remove the restrictions from deploy then it can be used to apply all kinds of resources and scenarios.

As an exercise try to deploy penfold [2]. It is a multi-container app with a database. It does not expose any routes. It is already trying to use the osio-pipeline but because of restrictions it can not deploy. As far as I can see those restrictions are the only impediment to support multi-clusters on the library.

I am really failing to see why we have required fields for deploy? Can you explain the reasons?

[1]

osio-pipeline/vars/deploy.groovy

Line 12 in 229a896

def required = ['ImageStream', 'DeploymentConfig', 'Service', 'Route', 'meta']

[2] https://github.com/gorkem/penfold