Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable PodUpload timeouts #3202

Closed
AdrianFarmadin opened this issue Jun 2, 2021 · 0 comments
Closed

Configurable PodUpload timeouts #3202

AdrianFarmadin opened this issue Jun 2, 2021 · 0 comments
Milestone

Comments

@AdrianFarmadin
Copy link
Contributor

The timeouts for PodUpload are hardcoded to 10s per connection and 120s for a request. This will cause problems for a large file transfer on slow network. It will be great to have these timeouts configurable.

public class PodUpload {
  private static final int DEFAULT_BUFFER_SIZE = 8192; 
  private static final int DEFAULT_CONNECTION_TIMEOUT_SECONDS = 10;
  private static final int DEFAULT_COMPLETE_REQUEST_TIMEOUT_SECONDS = 120;

https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java#L54
https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java#L87
https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java#L89

@manusa manusa added this to the 5.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants