Skip to content

Commit 1554955

Browse files
committed
Fix dependencies and packaging
1 parent 45f716f commit 1554955

File tree

2 files changed

+10
-41
lines changed

2 files changed

+10
-41
lines changed

log4j/pom.xml

Lines changed: 5 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -25,27 +25,27 @@
2525
</parent>
2626

2727
<artifactId>kubernetes-log4j</artifactId>
28-
<packaging>jar</packaging>
28+
<packaging>bundle</packaging>
2929
<name>Fabric8 :: Kubernetes :: Log4j Core components</name>
3030
<description>Provides a lookup to use Kubernetes attributes in a Log4j Core configuration.</description>
3131

3232
<properties>
3333
<osgi.export>io.fabric8.kubernetes.log4j.*</osgi.export>
3434
<osgi.import>*</osgi.import>
35+
36+
<!-- Dependency versions -->
37+
<log4j.version>2.22.1</log4j.version>
3538
</properties>
3639

3740
<dependencies>
3841
<dependency>
3942
<groupId>io.fabric8</groupId>
4043
<artifactId>kubernetes-client</artifactId>
4144
</dependency>
42-
<dependency>
43-
<groupId>io.fabric8</groupId>
44-
<artifactId>kubernetes-model-core</artifactId>
45-
</dependency>
4645
<dependency>
4746
<groupId>org.apache.logging.log4j</groupId>
4847
<artifactId>log4j-core</artifactId>
48+
<version>${log4j.version}</version>
4949
</dependency>
5050
<dependency>
5151
<groupId>org.assertj</groupId>
@@ -69,31 +69,4 @@
6969
</dependency>
7070
</dependencies>
7171

72-
<build>
73-
<plugins>
74-
<!-- Replace `jar:jar` execution with `bundle:bundle` -->
75-
<plugin>
76-
<groupId>org.apache.maven.plugins</groupId>
77-
<artifactId>maven-jar-plugin</artifactId>
78-
<executions>
79-
<execution>
80-
<id>default-jar</id>
81-
<phase>none</phase>
82-
</execution>
83-
</executions>
84-
</plugin>
85-
<plugin>
86-
<groupId>org.apache.felix</groupId>
87-
<artifactId>maven-bundle-plugin</artifactId>
88-
<executions>
89-
<execution>
90-
<id>generate-osgi-bundle</id>
91-
<goals>
92-
<goal>bundle</goal>
93-
</goals>
94-
</execution>
95-
</executions>
96-
</plugin>
97-
</plugins>
98-
</build>
9972
</project>

pom.xml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,11 @@
247247
<artifactId>crd-generator-api</artifactId>
248248
<version>${project.version}</version>
249249
</dependency>
250+
<dependency>
251+
<groupId>io.fabric8</groupId>
252+
<artifactId>kubernetes-log4j</artifactId>
253+
<version>${project.version}</version>
254+
</dependency>
250255
<dependency>
251256
<groupId>io.fabric8</groupId>
252257
<artifactId>kubernetes-model-core</artifactId>
@@ -712,15 +717,6 @@
712717
<type>pom</type>
713718
</dependency>
714719

715-
<!-- Log4j dependencies, imported as a BOM -->
716-
<dependency>
717-
<groupId>org.apache.logging.log4j</groupId>
718-
<artifactId>log4j-bom</artifactId>
719-
<version>${log4j.version}</version>
720-
<scope>import</scope>
721-
<type>pom</type>
722-
</dependency>
723-
724720
<dependency>
725721
<groupId>org.snakeyaml</groupId>
726722
<artifactId>snakeyaml-engine</artifactId>

0 commit comments

Comments
 (0)