Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

HTML/CSS: Space Dashboard Updates #925

Closed
2 of 3 tasks
AdamJ opened this issue Mar 12, 2018 · 11 comments
Closed
2 of 3 tasks

HTML/CSS: Space Dashboard Updates #925

AdamJ opened this issue Mar 12, 2018 · 11 comments
Assignees
Labels
code/HTML&CSS implementation of HTML/CSS
Milestone

Comments

@AdamJ
Copy link
Collaborator

AdamJ commented Mar 12, 2018

Update the Space Dashboards to match the new designs from UXD:
https://redhat.invisionapp.com/share/DQFLCG4G9YK

Visual Design Story #883

Verification Criteria:

  • Review with Michael D.
  • Review with UXD during Design Review session
  • Review with fabric8-ui dev leads
@AdamJ AdamJ added the code/HTML&CSS implementation of HTML/CSS label Mar 12, 2018
@AdamJ AdamJ added this to the Backlog milestone Mar 12, 2018
@AdamJ AdamJ self-assigned this Mar 16, 2018
@AdamJ AdamJ modified the milestones: Backlog, Sprint 146-1 Mar 16, 2018
@AdamJ
Copy link
Collaborator Author

AdamJ commented Mar 16, 2018

osio_spacedashboard_new

@AdamJ AdamJ added the blocked blocked from moving forward label Mar 16, 2018
@AdamJ
Copy link
Collaborator Author

AdamJ commented Mar 16, 2018

Implementation of the Feature Flag switcher is blocked due to issues with prod-preview after the migration. I'll keep track of any stability improvements and remove the blocker label when possible.

@AdamJ AdamJ modified the milestones: Sprint 146-1, Sprint 146-2 Mar 19, 2018
@AdamJ
Copy link
Collaborator Author

AdamJ commented Mar 21, 2018

The prod-preview environment is still too unstable to use. This issue will remain blocked until that environment is running properly.

@AdamJ
Copy link
Collaborator Author

AdamJ commented Mar 23, 2018

PR filed - closing this issue

@AdamJ AdamJ closed this as completed Mar 23, 2018
@AdamJ AdamJ mentioned this issue Mar 23, 2018
2 tasks
@andrewazores
Copy link
Member

andrewazores commented Apr 12, 2018

@mindreeper2420 not sure if there's a better place to ask, but is the EnvironmentWidget being permanently removed from the new Analyze dashboard? I see that it's present but commented out in the new dashboard template. I ask because that component is currently a consumer of the DeploymentsService, which we're refactoring to be internal to the Deployments area, and have a different service (DeploymentApiService) exported which the EnvironmentWidget should consume instead. Whether this component is obsoleted and will be removed from the upcoming redesigned dashboard or will live on in a future update will influence how I refactor the DeploymentsService, DeploymentApiService, and EnvironmentWidget.

(see openshiftio/openshift.io#2961)

@AdamJ
Copy link
Collaborator Author

AdamJ commented Apr 16, 2018

@andrewazores yes, the EnvironmentWidget is being removed from the Analyze Dashboard. Part of the Environments area of OSIO are being combined into the new Applications widget, in order to provide users a better overview of their setup.

@dlabrecq is currently working on connecting the Space Dashboard, so he would the best to speak with regarding the full implementation of the Applications widget.

@dlabrecq
Copy link

I'm planning on reusing the code found in the deployments details. I see that DeploymentDetailsComponent currently uses DeploymentsService. Will you refactor that to use DeploymentApiService?

@andrewazores
Copy link
Member

@dlabrecq DeploymentDetailsComponent will continue using the DeploymentsService, since that component is an "internal" Deployments area consumer. An external consumer like the Applications widget should not consume the DeploymentsService, and should instead use the DeploymentApiService.

@andrewazores
Copy link
Member

@mindreeper2420 do you have a timeline for when the new dashboard will become the default for all users, ie when the EnvironmentWidget can be removed? If it's still going to stick around for some time then I'll move ahead with my small patch to decouple it from the DeploymentsService. If it's only a matter of days then I'll simply wait for it to be removed, or help remove it.

@dlabrecq
Copy link

I don't believe we will remove the EnvironmentWidget as part of these changes. Although we won't show it in the new dashboard, I can see it being useful at some point in the future? For example, we talked about making the dashboard customizable, where users could swap out widgets.

@andrewazores
Copy link
Member

Okay, in that case I will move forward with refactoring the widget to consume the new service. Thanks for the info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code/HTML&CSS implementation of HTML/CSS
Projects
None yet
Development

No branches or pull requests

3 participants