Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving packages outside of this repo #145

Closed
alfonsogarciacaro opened this issue Mar 4, 2019 · 6 comments
Closed

Moving packages outside of this repo #145

alfonsogarciacaro opened this issue Mar 4, 2019 · 6 comments

Comments

@alfonsogarciacaro
Copy link
Member

Hi there!

First of all, thanks a lot for your contributions @forki, @toburger and @MangelMaxime! It's great to have several bindings available for React libraries. However, the approach of having a big repo with multiple packages is proving to be difficult to maintain, because I don't know the packages the bindings are targeting which makes reviewing, updating... difficult.

Because of this, and following what we're doing in other repos (fable-import, fable-powerpack) I'm planning to leave only the code for the Fable.React package here. Can you please move the other packages to your GH profile (or if you prefer, we can create another repo in fable-compiler org if you become the maintainers):

Thanks a lot for your help!

@MangelMaxime
Copy link
Member

Sure, I will move it under my GH profile.

@toburger
Copy link
Contributor

I have an existing repo where my transition group samples live: https://github.com/toburger/Fable.ReactTransitionGroup.Samples

I will rename it to Fable.ReactTransitionGroup or Fable.React.TransitionGroup (although there was a problem with this namespace, so I renamed it to the former one) and move the samples to a samples directory...
Let me know what else is needed to get it to work with the fable ecosystem.

@alfonsogarciacaro
Copy link
Member Author

That should be enough, thanks @toburger! 👏

@MangelMaxime
Copy link
Member

MangelMaxime commented Apr 2, 2019

For people who needs to move the project out of this repository:

Here is the last commit with the projects in the repo

@toburger
Copy link
Contributor

I've finally updated Fable.ReactTransitionGroup to the new API: https://github.com/toburger/Fable.ReactTransitionGroup 😅

@forki
Copy link
Collaborator

forki commented Apr 23, 2019

Ok I moved it to https://github.com/fable-compiler/Fable.ReactGoogleMaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants