Expand tilde in strings #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@fielding I let you rebase this branch, I will publish a new npm version after merging this PR. And don't worry about adding the first dependency, npm is made for that, let's not reinvent the wheel 👍 |
Normalize path strings Reapply normalize and untildify functions to path after rebasing
fielding
force-pushed
the
fix/tilde-expansion
branch
from
64cb77c to
9b6bb97
Compare
Contributor
Author
|
Rebased and squashed branch. It should be good to go now Once this is merged I will rebase and submit the PR that implements the feature requested in #7 Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on your shell and it's configuration, tilde might not be expanded to the user's home directory or might only expand at the beginning of a word or after specified characters, i.e. '='. This pr updates git2json to untildify path strings itself, so that the user doesn't have to worry about the shell expanding the paths or under what conditions the shell might do so.
I also normalized the path string using node's path.normalize for good measure.
Both of the above changes will be of great value for the PR I will be submitting soon for #7.
If you don't like the addition of the first true dependency let me know and I can just add an untildify function to git2json.js.