Skip to content

Commit d6f204d

Browse files
committed
setTextIsSelectable onAttachedToWindow
Code Review from ShikaSD facebook#28952 (comment) A similar solution was merged to master for a similar problem with TextInput inside FlatList facebook#28852
1 parent b01c4d5 commit d6f204d

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import static com.facebook.react.views.text.TextAttributeProps.UNSET;
1111

1212
import android.content.Context;
13-
import android.graphics.Canvas;
1413
import android.graphics.drawable.Drawable;
1514
import android.os.Build;
1615
import android.text.Layout;
@@ -437,12 +436,12 @@ public void onStartTemporaryDetach() {
437436

438437
public void setSelectableText(boolean value) {
439438
mSelectableText = value;
440-
invalidate();
441439
}
442440

443441
@Override
444442
public void onAttachedToWindow() {
445443
super.onAttachedToWindow();
444+
setTextIsSelectable(mSelectableText);
446445
if (mContainsImages && getText() instanceof Spanned) {
447446
Spanned text = (Spanned) getText();
448447
TextInlineImageSpan[] spans = text.getSpans(0, text.length(), TextInlineImageSpan.class);
@@ -464,12 +463,6 @@ public void onFinishTemporaryDetach() {
464463
}
465464
}
466465

467-
@Override
468-
public void onDraw(Canvas canvas) {
469-
super.onDraw(canvas);
470-
setTextIsSelectable(mSelectableText);
471-
}
472-
473466
@Override
474467
public boolean hasOverlappingRendering() {
475468
return false;

0 commit comments

Comments
 (0)