Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #192

Merged
merged 13 commits into from
Dec 6, 2021
Merged

Minor fixes #192

merged 13 commits into from
Dec 6, 2021

Conversation

eigenraven
Copy link
Collaborator

@eigenraven eigenraven commented Dec 6, 2021

Minor code tidying fixes for a bunch of compiler warnings:

  • Adding default initializers to fields without one
  • Remove padding by reordering members in a couple of structs
  • A few trivial copy->move changes
  • Use = defaulted constructors and destructors where appropriate
  • Also fixes a flaky PTP test, it was modifying an atomic just after rather than before the barrier.
  • PTP group race condition fix
  • Attempt to make scheduler tests less unreliable under TSan: with tsan overheads, I think the executor was able to finish executing its dummy task before the scheduler was able to execute the next one, resulting in re-use where it normally wouldn't occur

This should fix all of the current TSan issues listed in #189

Copy link
Collaborator

@Shillaker Shillaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 👍

@eigenraven
Copy link
Collaborator Author

@Shillaker can you merge? "The base branch restricts merging to authorized users"

@Shillaker
Copy link
Collaborator

@KubaSz think I've given you sufficient permissions now. Let me know if not.

@eigenraven eigenraven merged commit 08e4876 into master Dec 6, 2021
@eigenraven eigenraven deleted the minor-fixes branch December 6, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants