Re-use conan cache for built dependencies #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
reuse-conan-cache
branch
from
1c92b5c
to
16e874e
Compare
Shillaker
reviewed
Nov 29, 2021
.github/workflows/tests.yml
Outdated
| @@ -37,8 +37,50 @@ jobs: | |||
| - name: "Check C/C++ formatting changes" | |||
| run: git diff --exit-code | |||
|
|
|||
| conan-cache: | |||
There was a problem hiding this comment.
See question on #182 re. how large this cache will be and GHA limit on cache size.
|
@csegarragonz This needs updating to the different cache key generation as now present in #182 to fix the broken hashFiles call |
csegarragonz
force-pushed
the
reuse-conan-cache
branch
2 times, most recently
from
ade7cc1
to
257261d
Compare
csegarragonz
force-pushed
the
reuse-conan-cache
branch
from
257261d
to
9955c9c
Compare
|
Looks like examples need a separate cache key, as they are building in release mode rather than debug like the other tests. |
csegarragonz
force-pushed
the
reuse-conan-cache
branch
2 times, most recently
from
6ddc570
to
3443f01
Compare
csegarragonz
force-pushed
the
reuse-conan-cache
branch
4 times, most recently
from
e741fda
to
801ba27
Compare
csegarragonz
force-pushed
the
reuse-conan-cache
branch
from
801ba27
to
a62f553
Compare
eigenraven
requested changes
Dec 1, 2021
Shillaker
requested changes
Dec 1, 2021
eigenraven
approved these changes
Dec 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cherry pick this change from #182, and faasm/faasm#542.
Upon cache hit the tests workflow file runs in under 7'.