Fixes for MPI message graph - #173
Merged
Merged
Conversation
csegarragonz
force-pushed
the
fixes-exec
branch
from
November 9, 2021 07:50
293860b to
19056e8
Compare
csegarragonz
marked this pull request as ready for review
November 9, 2021 07:50
csegarragonz
force-pushed
the
fixes-exec
branch
from
November 9, 2021 07:51
19056e8 to
33dc447
Compare
Shillaker
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I fix two bugs I encountered while testing the MPI message graph.
First, the way we cached the message that initialised a rank meant that only messages creating a new world (or initialising it in a different host) would get the updated details. Note that the other ranks would inherit a message with the right flags, but would never update it locally. I add a regression test to check that non-master ranks also populate the message details.
Second, I was eventually running into a RapidJSON memory corruption when requesting the result from
redis. There was a problem with the scope of the variables used, which I also fix.