Remove dependency on StringLike class #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB Most of the diff here is from running purty. We should really be enforcing that purty is clean on merge to master. The only real change is in this file and then updating everywhere we use that.
The only place where we have this dependency is https://pursuit.purescript.org/packages/purescript-parsing/6.0.2/docs/Text.Parsing.Parser.String#v:anyChar
This really didn't make any sense anyway because it makes no sense to take a char from a
HexString, you can only take bytes which means taking twoChars at a time. This PR corrects this problem, and allows for us to upgrade topurescript-parsingv7.0.0 whenever we update the underlyingpurescript-eth-corelib