SwiftUI로 리팩토링 해보기 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p into refactor/swiftUI_View
|
고생하셨습니다. |
f-lab-jercy
reviewed
Feb 23, 2024
| @@ -8,11 +8,79 @@ | |||
| import SwiftUI | |||
|
|
|||
| struct ExerciseList: View { | |||
| @StateObject var viewModel: ExerciseViewModel | |||
There was a problem hiding this comment.
여기서 stateobject를 쓰신 이유가 있을까요?
@ stateobject, @ observedObject, @ state @ bind의 차이점이 뭘까요?
Comment on lines
+38
to
+64
| final class MockViewModel: ExerciseViewModel { | ||
| init() { | ||
| super.init( | ||
| useCase: Training( | ||
| repository: TrainingRepository( | ||
| trainingDataSource: TrainingDataSource()) | ||
| ) | ||
| ) | ||
|
|
||
| self.program = [ | ||
| TrainingLevel( | ||
| id: UUID().uuidString, | ||
| name: "Starter", | ||
| description: "여긴 해당 설명이 들어갑니다.", | ||
| routine: [ | ||
| DailyRoutine(day: "Day 01", routine: [3,2,1,1]), | ||
| DailyRoutine(day: "Day 01", routine: [3,2,1,1]), | ||
| DailyRoutine(day: "Day 01", routine: [3,2,1,1]), | ||
| DailyRoutine(day: "Day 01", routine: [3,2,1,1]), | ||
| DailyRoutine(day: "Day 01", routine: [3,2,1,1]) | ||
| ] | ||
| ), | ||
| TrainingLevel( | ||
| id: UUID().uuidString, | ||
| name: "Starter", | ||
| description: "여긴 해당 설명이 들어갑니다.", | ||
| routine: [ |
There was a problem hiding this comment.
mock이 view에 있는게 좋을까요? viewModel에 있는게 좋을까요?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainView를 ExerciseList로 리팩토링해서 호출까지 했습니다 ~!