Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various built-in functions are not exact. #207

Closed
RobertZenz opened this issue May 26, 2019 · 3 comments
Closed

Various built-in functions are not exact. #207

RobertZenz opened this issue May 26, 2019 · 3 comments
Labels
enhancement

Comments

@RobertZenz
Copy link
Collaborator

Various built-in functions are not exact and rely on doubles. If possible these should be swapped to BigDecimal implementations.

I'm not sure where to get those, though. It's just something that I just noticed.
@RobertZenz
Copy link
Collaborator Author

big-math seems to implement these functions already, but depending on it doesn't seem to be a very good option.

Everybody can fix this, though, by overriding the functions in the Expression after it is being created. I'm not sure how to approach this. The big-math library is MIT licensed, theoretically the source could be embedded, but depending on it would be nicer. But I'm not sure if a dependency is something you want.

@uklimaschewski
Copy link
Collaborator

FYI: Just started working on an add-on library that replaces and extends the current implementations.

@uklimaschewski
Copy link
Collaborator

I have just released the first version of the EvalEx big-math extension.
See the announcement here: #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobertZenz @uklimaschewski