Skip to content

Conversation

@nikkii94
Copy link
Contributor

@nikkii94 nikkii94 commented Oct 31, 2024

Fixes deprecation error for "Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated"

…ect) of type array|string is deprecated fix
@nikkii94 nikkii94 changed the title Deprecated: preg_replace(): Passing null to parameter #3 ($subject) o… fix: Deprecated: preg_replace(): Passing null to parameter #3 ($subject) o… Oct 31, 2024
@ezyang
Copy link
Owner

ezyang commented Nov 1, 2024

Do you have a test that exercises this? It seems to be html should never be null

@nikkii94
Copy link
Contributor Author

nikkii94 commented Nov 1, 2024

No, but I found this in my error log multiple times

Copy link
Owner

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not great but whatever

@ezyang ezyang merged commit 5d154a2 into ezyang:master Nov 10, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2025
# [4.19.0](v4.18.0...v4.19.0) (2025-10-17)

### Bug Fixes

* add warning for misleading option ([#433](#433)) ([b21a591](b21a591))
* catastrophic backtracking in Core.AggressivelyFixLt ([#440](#440)) ([418eeb7](418eeb7))
* Deprecated: preg_replace(): Passing null to parameter [#3](#3) ($subject) o… ([#421](#421)) ([5d154a2](5d154a2))
* non-substantive typos ([#434](#434)) ([c2bc354](c2bc354))

### Features

* Add CSS direction support ([#429](#429)) ([63e631e](63e631e))
* Add option for safe iframe hosts using array lookup ([#423](#423)) ([b5cbf0c](b5cbf0c))
* Allow more image widths by default ([#430](#430)) ([00a0748](00a0748))
* Define option URI.AllowedSymbols ([#447](#447)) ([77ebd08](77ebd08))
* PHP 8.4 support ([#441](#441)) ([ff005f6](ff005f6))
* Support PHP 8.5 versions ([#453](#453)) ([1eb05d9](1eb05d9))
@github-actions
Copy link

🎉 This PR is included in version 4.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants