Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make locally-built ghstack easier to use #45

Open
samestep opened this issue Feb 25, 2021 · 1 comment
Open

Make locally-built ghstack easier to use #45

samestep opened this issue Feb 25, 2021 · 1 comment
Labels

Comments

@samestep
Copy link
Collaborator

samestep commented Feb 25, 2021

After the migration to Poetry (#32), it's a bit more difficult to use ghstack (e.g. for experimentation, to check or validate behaviors) while locally developing it. The solution given in the README is to use poetry shell, but that is a bit unergonomic because it requires one to cd into their clone of ghstack, run poetry shell, then cd out again.

One alternative could be to put a shell script like this on your PATH (assuming your clone of ghstack is in ~/github/ezyang/ghstack):

#!/usr/bin/env bash
$(cd ~/github/ezyang/ghstack && poetry run which ghstack) "$@"

The downside of this is of course that it has a hardcoded path. Maybe it would be worth it to add a Makefile to this repo such that make install automatically puts such a file on the PATH, using the actual path to the repo clone for the cd subshell command.

@samestep samestep self-assigned this Feb 25, 2021
@ezyang
Copy link
Owner

ezyang commented Feb 25, 2021

I think this poetry upstream bug is relevant python-poetry/poetry#34

@samestep samestep removed their assignment Aug 16, 2021
@ezyang ezyang added the backlog label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants