Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve branch structure #974

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

allaboutevemirolive
Copy link

@allaboutevemirolive allaboutevemirolive commented May 7, 2024

Following PR #933:

This PR only includes related output tests of .sdout for the --tree argument and discards the rest.

If this PR passes the CICD, I will close PR #933.

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, could you change Refactor: to refactor: in your commit summary for consistency?

@allaboutevemirolive allaboutevemirolive changed the title Refactor: Improve branch refactor: Improve branch May 8, 2024
@allaboutevemirolive allaboutevemirolive changed the title refactor: Improve branch refactor: Improve branch structure May 8, 2024
@allaboutevemirolive
Copy link
Author

@cafkafk Done :)

@cafkafk
Copy link
Member

cafkafk commented May 8, 2024

@cafkafk Done :)

I'm not sure if this is a glitch in the mobile ui, but I meant the commit summary, not the pr summary. I may fix this for you in a moment.

@allaboutevemirolive
Copy link
Author

allaboutevemirolive commented May 8, 2024

@cafkafk Done :)

I'm not sure if this is a glitch in the mobile ui, but I meant the commit summary, not the pr summary. I may fix this for you in a moment.

I hope I'm doing it correctly. Pull the current changes to the local machine, use git amend to update the git summary, and push back to this branch.

@cafkafk

@cafkafk
Copy link
Member

cafkafk commented May 16, 2024

@cafkafk Done :)

I'm not sure if this is a glitch in the mobile ui, but I meant the commit summary, not the pr summary. I may fix this for you in a moment.

I hope I'm doing it correctly. Pull the current changes to the local machine, use git amend to update the git summary, and push back to this branch.

@cafkafk

Looks like you missed one :p

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants