Skip to content

Commit c11aa91

Browse files
committed
[BugFix] Find duplicates w/bin search ignored 0th element. Tests didn't call bin search.
1 parent d9a69f4 commit c11aa91

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

searches/find_duplicates.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def duplicates_bin_search(arr1, arr2):
4242
output = []
4343

4444
for element in arr1:
45-
if binary_search(arr2, element) > 0:
45+
if binary_search(arr2, element) >= 0:
4646
output.append(element)
4747

4848
return output

tests/test_find_duplicates.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ def test_pre_sorted(self):
1212
self.assertNotEqual([1,2,3], duplicates_pre_sorted([5,7,1,9,2,10,3],[4,90,23,1,53,3,2,22]))
1313

1414
def test_bin_search(self):
15-
self.assertEqual([1,2,3], duplicates_linear([1,2,3,4,5,6],[1,2,3,7,8,9]))
16-
self.assertEqual([1,2,3], duplicates_linear([1,2,3,4,5,6],[1,2,3,7,8,9,10,11,12,13,14,15]))
15+
self.assertEqual([1,2,3], duplicates_bin_search([1,2,3,4,5,6],[1,2,3,7,8,9]))
16+
self.assertEqual([1,2,3], duplicates_bin_search([1,2,3,4,5,6],[1,2,3,7,8,9,10,11,12,13,14,15]))
1717

1818
def test_bin_search_second_shorter(self):
19-
self.assertEqual([1,2,3], duplicates_linear([1,2,3,7,8,9,10,11,12,13,14,15],[1,2,3,4,5,6]))
19+
self.assertEqual([1,2,3], duplicates_bin_search([1,2,3,7,8,9,10,11,12,13,14,15],[1,2,3,4,5,6]))

0 commit comments

Comments
 (0)