Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ancillary pages and corresponding menu nav items #1484

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

crandmck
Copy link
Member

@crandmck crandmck commented Apr 11, 2024

Per discussion in TC and:

Details are laid out in https://github.com/expressjs/expressjs.com/wiki/Discuss:-Remove-pages-from-docs.

Not previously discussed: The home page has a "Frameworks" tile with a link to one of the pages being removed.

  • For the English page, I replaced this with
      <h3>Middleware</h3> 
      Express is a routing framework with minimal functionality of its own.  A lot of
      functionality is contained in Express <a href="{{ page.lang }}/resources/middleware.html">middleware</a> modules.
  • For non-en pages, I removed the text with no replacement.

@crandmck crandmck requested review from a team and wesleytodd and removed request for a team and wesleytodd April 11, 2024 04:14
Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the english removals. We are nuking some whole pages, but also removing references to those pages from other content, which is why the diff is as large as it is.

I left a suggestion for wording, LGTM either way though

index.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants