docs: document http-terminator (fixes #1096) #1097
Conversation
There was a problem hiding this comment.
Edit: I've requested one change, but otherwise...
LGTM 👍
This package actually looks quite good too btw, kudos!
P.S. the failing CI doesn't have anything to do with this PR.
The CI was failing before this PR, but there is one styling error introduced by it, which I suggested a change on. ❤️
|
Do I need to do anything regarding the failing tests? |
|
This is not a judgement on the package, but I would like to see the express documentation have less documentation on third party packages. Today there is a ton of outdated stuff which was added years ago, and I would like to not make it any worse. I think we should consider moving stuff like this into an "awesome list" format instead of it being on the express website. Thoughts about this direction @jonchurch? |
What makes that different from the current format? |
|
We wouldn't maintain it :) The problem with it on the website is it makes us already limited maintainers have more work. In an awesome list I, and I am guessing the other primary maintainers would not maintain it. |
|
I think having a discussion about cleaning up the site would be fruitful. IMO the site should document the project and not much else. However, as things stand we do have these kind of sections and I think OP’s library is high quality so Im pro merging. These kinds of sections (recommendations of libraries) can always be removed in the future, and I think it would be pragmatic to move towards that. |
There was a problem hiding this comment.
I know there was a bunch of conversation in this PR revolved around the greater idea on 3-rd party modules, but they are there today, and this one is really nice, so I'm going to merge it in and if there is ever a policy in the future, it's easy to adjust the contents at that time 👍
|
Thank you! |
No description provided.