docs: add project captains to contribution #5484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
force-pushed
the
repocaptians
branch
from
97b5ddd to
e80c969
Compare
UlisesGascon
approved these changes
Feb 16, 2024
|
@wesleytodd this is not ready yet to merge, right? I think you said you were going to make one more change? |
wesleytodd
force-pushed
the
repocaptians
branch
from
e80c969 to
e394da4
Compare
|
Ok, updated with that last change. I think this should be good to merge. Not I stacked this on top of the other TC changes, so might be easiest to merge this to that then merge that one, but up to you @dougwilson as you are going to merge them up tonight for the patch. |
UlisesGascon
approved these changes
Feb 18, 2024
dougwilson
force-pushed
the
repocaptians
branch
from
e394da4 to
59aae76
Compare
dougwilson
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #4210
I believe I addressed the issues from #4210, specifically the "participate as a committer". I had one comment about "the other captains getting a vote", my intent was that if there is a disagreement from existing captains on a new member, that should be taken into account. Do folks feel like this is important? Or can we land as is?
Also of note, I did end up opening a new PR because there was quite a bit of noise in there.