Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update TC governance rules #5483

Closed
wants to merge 1 commit into from
Closed

docs: update TC governance rules #5483

wants to merge 1 commit into from

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Feb 16, 2024

As discussed in expressjs/discussions#161

  1. Adds min/max size
  2. Adds inactive and re-active processes
  3. Changes nomination from any committer to any TC member (not discussed in the meeting, I am not tied to that change but seemed logical, can remove if folks object).
  4. Added bit about admin on project owned resources

@wesleytodd wesleytodd requested a review from a team February 16, 2024 14:55
@wesleytodd wesleytodd force-pushed the tc-gov branch 2 times, most recently from a9968f6 to f0b565b Compare February 16, 2024 14:57
Contributing.md Outdated Show resolved Hide resolved
@wesleytodd
Copy link
Member Author

wesleytodd commented Feb 16, 2024

Ah, my habit of conventional commits and I forgot we don't do that here. Will amend.

@wesleytodd
Copy link
Member Author

Also, I was just poking around and I think we need to consolidate some of this. I updated contributing, but noticed that we also had some duplication with the charter: https://github.com/expressjs/express/blob/master/Charter.md

@wesleytodd wesleytodd changed the title feat(docs): update TC governance rules docs: update TC governance rules Feb 16, 2024
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this great refresh @wesleytodd.

Just a minor comment from my side, I think that is implicit that any active TC member can request at any time to become inactive (as a personal decision) and this should be a simple process like open a PR a ask for the change. Not sure if we have the need to make it explicit 🤔

@wesleytodd
Copy link
Member Author

I think that is implicit that any active TC member can request at any time to become inactive (as a personal decision) and this should be a simple process like open a PR a ask for the change. Not sure if we have the need to make it explicit

I am not super opinionated on this topic, but I think that err'ing in the side of more explicit for governance docs is good. Happy to hear others thoughts on the topic and edit before we merge. Also nothing is set in stone, we can change it with a fast follow PR if we like as well.

@crandmck
Copy link
Member

crandmck commented Feb 16, 2024

LGTM.

I see you updated the "Active" list on https://expressjs.com/en/resources/community.html, thanks! Do we also need to keep the "Inactive" list there? Does it provide any value?

@wesleytodd
Copy link
Member Author

Do we also need to keep the "Inactive" list there? Does it provide any value?

Good question. I feel like it doesn't hurt and recognizes folks for their work even if it was in the past. I also wouldn't argue against moving it into a repo and removing it from that page. I don't feel strongly either way.

@crandmck
Copy link
Member

crandmck commented Feb 17, 2024

It's of course nice to recognize people for their contribs, but it begs the question of how long we keep a name there after someone is inactive--forever? And who qualifies for this list... I suspect there are names missing who made significant contributions in the past (e.g. TJ). Rather than go down this rabbit hole, I think moving this info elsewhere less prominent makes sense. Where would be appropriate?

Contributing.md Outdated Show resolved Hide resolved
Contributing.md Show resolved Hide resolved
@wesleytodd
Copy link
Member Author

Rather than go down this rabbit hole, I think moving this info elsewhere less prominent makes sense. Where would be appropriate?

Yeah I think that is a strong argument. I am 👍 to removing the inactive section.

@wesleytodd
Copy link
Member Author

Ok, I think 2 days and a few approvals here (especially since this was discussed on the meeting) is enough to merge this. I am going to merge this now and follow up with a consolidation pass on the charter.md and this doc. I think technically at least the TC structure stuff belongs in the charter.

@dougwilson
Copy link
Contributor

Yep, sound good. May want to hold off merge until tonight so I can do it with the patch stuff I started

@dougwilson
Copy link
Contributor

Otherwise good rebase and stuff which I can do. Sorry, I meant to have it done this morning bc we had that little mix up 😢

@wesleytodd
Copy link
Member Author

Sounds good, do you want to merge it when you are ready then?

@dougwilson
Copy link
Contributor

Ya, if it's all good I will drop in in tonight as-is

Comment on lines +126 to +128
Inactive status members can become active members by self nomination if the TC is not already
larger than the maximum of 10. They will also be given preference if, while at max size, an
active member steps down.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the comment party, but the lawyer in me (disclaimer: definitely not a lawyer) thinks this verbiage should be removed. I don't see how it adds any real value.

I'm imagining a case where a TC member is [involuntarily] removed due to inactivity, but disagrees with the decision. This verbiage would allow them to "self-nominate" and demand they be given preference over other, possibly more desirable candidates.

If a candidate previously served on the TC, the active TC can (and I'm sure will) consider that experience appropriately. There's no need to codify it as part of the governance rules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the comment party

No worries, we figured this might need more edits after.

I'm imagining a case where a TC member is [involuntarily] removed due to inactivity, but disagrees with the decision. This verbiage would allow them to "self-nominate" and demand they be given preference over other, possibly more desirable candidates.

Yeah that was sort of the intent I was thinking of, but I totally see your point. I am not sure which is more important:

  1. ensuring new folks have an opportunity
  2. protecting current maintainers who may burn out and need to step in and out of the role

I agree though, not having these words in the governance gives more freedom for interpretation. Would love to hear others thoughts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants