Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favicon-related bug in cookie-sessions example #5414

Conversation

DmytroKondrashov
Copy link

Added the check for /favicon request in " count" middleware. Without this check, a request to /favicon that is made by most browsers will also increment the counter. This will lead to unwanted behaviour when a reload of a page will increment the counter for 2 instead of 1.
image

@dougwilson dougwilson force-pushed the fix-bug-in-cookie-sessions-example branch from 37d2647 to 0e3ab6e Compare February 19, 2024 21:48
@dougwilson dougwilson merged commit 0e3ab6e into expressjs:master Feb 20, 2024
24 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants