-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: cookie@0.6.0 #5404
deps: cookie@0.6.0 #5404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @rhodgkins
Thank you @rhodgkins ! Would you be willing to add the new features this exposes to our test suite? A PR do our expressjs.com repo to add the new option would also be very appreciated. |
@dougwilson no problem, test added. |
And docs updated expressjs/expressjs.com#1456 |
Sorry for the bump @dougwilson but is this ok now let me know if you need anything else. Thanks |
Any ETA of getting it merged? We need support of partitioned cookie in our project. @dougwilson |
Hello, the Express project is doing a bit of regrouping is all. We will begin to work on a new version roll out soon. |
Any luck with the progress on this, we cannot set auth cookies anymore, is there a workaround until this is complete? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
not trying to spam or to be a bother I noticed this got some attention since yesterday, would this be merged anytime soon or is there a workaround, this is a huge pain point ATM |
Hey @1finedev, no worries about spamming, but also no need to ping individual contributors. Most of us are following all these repos for all activity, so the ping doesn't help. We are mostly done with the regrouping and landed our first release last week. I will look at this one now, but my first question for @UlisesGascon is if there was a reason we did not land this before the last release. Was it just overlooked? I am unclear why we wouldn't have just merged if it was all good previously so just want to make sure we were not missing something. |
Hi again, please is there any chance this can be merged. Thanks |
Ah sorry I was supposed to reply here and forgot. So we will be working toward another release, but for the time being you can install the already published cookie package and use it instead of the bundled version from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I will amend the History.md
when merging this change, I will land this next Monday, and then it will be included in the next release (no date yet)
@UlisesGascon has this gone in any of the recent releases? I couldn't see anything in the release notes so thought I'd check... |
Ah ignore me, it's in Thanks 👍 |
To allow
partitioned
option to be used.