tests: use cb() instead of done()#5233
Merged
dougwilson merged 1 commit intoexpressjs:masterfrom Feb 19, 2024
Merged
Conversation
dougwilson
pushed a commit
to kristof-low/express
that referenced
this pull request
Sep 28, 2023
dougwilson
force-pushed
the
test-typo-fixes
branch
from
74dc4bc to
972e9e0
Compare
dougwilson
force-pushed
the
test-typo-fixes
branch
from
972e9e0 to
2a89eb5
Compare
wesleytodd
approved these changes
Feb 19, 2024
Merged
This was referenced Mar 26, 2024
This was referenced May 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed two uses of the
done()callback tocb()since, as far as I can tell, this is what was intended.Also, I changed the reassignment of the
done()callback to creating a newcb()callback, since this is less confusing and more consistent with the rest of the tests.If these changes are mistaken, please let me know.