Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearCookie should probably only set one header per cookie name test case #4542

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

clearCookie should probably only set one header per cookie name test case #4542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/res.clearCookie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,20 @@ describe('res', function(){
.expect('Set-Cookie', 'sid=; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT')
.expect(200, done)
})

it.only('should not only output one setCookie header per cookie name', function(done){
var app = express();

app.use(function(req, res){
res.cookie('sid', 'foo');
res.clearCookie('sid').end();
});

request(app)
.get("/")
.expect("Set-Cookie", "sid=; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT")
.expect(200, done)
})
})

describe('.clearCookie(name, options)', function(){
Expand Down