Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4171 depd #4174

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 5, 2020

Main Changes

  • Upgrade to depd@2.0.0

Context

History.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@dougwilson dougwilson added the deps label Feb 5, 2020
@UlisesGascon
Copy link
Member Author

If you agree I will close the PR as setprototypeof is duplicated #4011, depd and cookie-signature are moved to 5.0.

@dougwilson
Copy link
Contributor

Sure, though I didn't see a reason for the depd move (though I'm not going to say otherwise), but just wanted to clarify in case you thought maybe I said to move that one to 5.0.

@dougwilson dougwilson added the pr label Mar 10, 2020
@dougwilson dougwilson added this to the 4.18 milestone Apr 23, 2020
@dougwilson
Copy link
Contributor

I have been working to snake the depd update through all the sub dependencies in play here so we can land an eval-free depd in our (maybe last) 4.x release.

@dougwilson dougwilson changed the base branch from master to 4.18 May 11, 2020 05:09
@dougwilson dougwilson mentioned this pull request May 20, 2020
20 tasks
@dougwilson
Copy link
Contributor

Ok, just as an update I am on the last major module that needs the update: http-errors. It will bump the major of that module, but I made sure that it would not affect the major version of anything within express depending on it so it will actually work out 🎉 . I am planning to have this all completed this week.

@davidje13

This comment has been minimized.

@dougwilson

This comment has been minimized.

@dougwilson dougwilson merged commit 1cc8169 into expressjs:4.18 Mar 26, 2022
@UlisesGascon UlisesGascon deleted the feature/4171-depd branch April 2, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants