-
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Express v4 -> v5 Migration #5944
Comments
Thanks for creating this issue. I added a reference in the 5.x backlog expressjs/discussions#266 👍 |
We have not set a date yet. Largely it depends on how quickly we can get the docs and the rest of the ecosystem dependencies (like DT for example) updated. We also have an LTS proposal we are working on to better schedule this stuff in the future.
Yes, this is part of the docs we need to write.
We would love to chat with the DT folks to get better at this in the future. We know it has lacked attention for too long, but we never had a lot of folks signing up and showing up to help us with this. If that is changing now I would love it, but we need more than just drive by help, we need folks who are here to help us get all the ~30 some packages we maintain all doing this consistently and well. There are existing issues for all of this, I will edit this comment when I get a chance to add them, but wanted to get this written sooner rather than later. |
Calling @borisyankov @CMUH @puneetar @dfrankland |
I might be able to help with type work |
@aredridel That would be awesome! I have been super busy keeping up with the chatter around the release while trying to spare some time for my paying job 😆, so I have not had a chance to pull in all the links to previous conversations around this, but most are in https://github.com/expressjs/discussions |
The author of the original PR to DefinitelyTyped is sick. |
OK. I fixed all issues in my PR to types of Express 5 — DefinitelyTyped/DefinitelyTyped#70563 |
@RobinTail perhaps it would be better to coordinate the efforts towards upstreaming the types here in the Express repo? And then subsequently to deprecate the |
Perhaps, @jonkoops . |
I have not, but I would not mind taking this on. I see also @aredridel volunteered for this, so perhaps they already started working on it. Let me know, I could set up a PR where we can collaborate. |
You know, in my system of values getting things done is more important and cherished rather than
So, I have done it. |
I'd say get the PR merged for the the |
Exactly, @jonkoops !
Anyway, it's a new workflow to establish — it will take time and moreover, as a new feature, it will require a new version — |
This is already the case now, with the added complexity (for end users) of it being a separate package. The only downside of moving them in here would be that maintenance needs to happen in this repo, which is totally fine as long as it's taken into account going forward. |
@RobinTail, is this still the correct way to add additional properties to the request object in Express TypeScript? declare global {
namespace Express {
export interface Request { // do I need export here
someProperty: string
}
}
}
export {} Also, is it compatible with |
This part wasn't changed, @walmartwarlord . If that augmentation did work for v4, it should work for v5 as well. |
Migration guide to Express 5 https://expressjs.com/en/guide/migrating-5.html |
Irrelevant to some extend, but, any news on when v5 will become the default version on npm? I read this issue: #4920 But the last comment there was stating 2023 and now we are entering 2025. I am not sure if this is normal. |
We have had a flurry of events and distractions among the TC members, primarily we have a few deadlines we have been focused on (the STF grant proposal and planning) which will be wrapped up soon. Luckily a lot of folks have been doing great work on the docs and other things we needed to get done, and so as soon as we have time to get back to this it will be the top priority. My guess is that we won't likely push the button on it until the new year to save folks from a lot of noise over the holidays. That said, we have not discussed it directly yet so I would love to hear others opinions. |
Just to fill you in as why I brought up this topic here is this "discussion" I had in |
@wesleytodd apologies for bugging you here, but I was wondering if you could give me a ballpark estimate for when v5 might become the default version. The reason I'm asking is that the NestJS v11 release is pretty much ready to go. However, I'd like to make Express v5 the default as part of the next major release. If the Express team is thinking that a Q1 release is feasible, I'd consider postponing and waiting. On the other hand, if it's likely to take a few more months, I'll move forward with what we have now and include it in a future release instead. Thanks in advance! |
No problem @kamilmysliwiec, happy to hear from you and your plans to udpate! We just discussed on the TC call today and we think we will be targeting early Jan for promoting to |
Excellent, thank you @wesleytodd! |
Copied from my comment in the Release 5.0 PR:
Maybe I missed a v5 planning document somewhere - I'm looking for a few details to help determine how and when to migrate our projects:
express@5.0.0
be published to the npmlatest
tag?breaking
note inHistory.md
@types/express
and@types/express-serve-static-core
? Does anything need to be changed here? Specifically, things like [@types/express-serve-static-core] 🏷️ AddPromise<void>
toRequestHandler
's return type DefinitelyTyped/DefinitelyTyped#69660 (comment) cc DT maintainers @borisyankov @samijaber @NatoBoram @bombillazo @AndrewLeedham @gabritto @sandersnThe text was updated successfully, but these errors were encountered: