Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multipart example or create new example for multer? #5193

Closed
riddlew opened this issue May 17, 2023 · 2 comments · Fixed by #5195
Closed

Update multipart example or create new example for multer? #5193

riddlew opened this issue May 17, 2023 · 2 comments · Fixed by #5195
Labels

Comments

@riddlew
Copy link
Contributor

riddlew commented May 17, 2023

Multer seems to be more up-to-date and is a popular choice for handling multipart data. I was wondering if the existing multipart example should be updated to use multer, or if there should be an example separate from the multiparty example? If so, I'd be more than happy to submit a PR for this.

@dougwilson
Copy link
Contributor

With a middleware (i.e. multer) the example isn't even necessary. Changing it to be how to use the multer middleware is just duplicating the multer docs. The examples/ dir here is examples for how to use the Express API. So in summary, I think it can just be removed as no longer needed.

@pjohanneson
Copy link

If this has been removed, it should probably be removed from the website where the docs are, too.

https://expressjs.com/en/starter/examples.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants