Shouldn't app.set("case sensitive routing") propagate to new Routers?

[ibc]

Just wondering if app settings such as "case sensitive routing" should be also applied in new Router instances created by the user.

Of course that would require some kind of magic in what express.Router returns (it should be a function that creates a new Router and applies the app settings unless provided by the user).

[ibc]

Sorry, express.Router() cannot return an instance with same settings as the app. Of course it should be done via a new method app.Router().

[dougwilson]

There will likely be a app.createRouter(opt) in 5.0, that would create a router with the opt merged with the app's options.

[ibc]

Something like this works:

Application.prototype.Router = function(options) {
    options = options || {};

    if (! options.hasOwnProperty('caseSensitive')) {
        options.caseSensitive = this.enabled('case sensitive routing');
    }

    if (! options.hasOwnProperty('strict')) {
        options.strict = this.enabled('strict routing');
    }

    return new Router(options);
};

and then:

var router = app.Router(options);