Skip to content

Commit efbe177

Browse files
committed
Override params every layer.
1 parent 8e3d0a6 commit efbe177

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

lib/router/index.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,7 @@ proto.handle = function(req, res, done) {
183183
}
184184
}
185185

186-
req.params = req.params || {};
187-
188-
for (var key in layer.params) {
189-
req.params[key] = layer.params[key];
190-
}
186+
req.params = layer.params;
191187

192188
// this should be done for the layer
193189
return self.process_params(layer, req, res, function(err) {

test/Router.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ describe('Router', function(){
3434
var another = new Router();
3535

3636
another.get('/:bar', function(req, res){
37-
req.params.foo.should.equal('test');
3837
req.params.bar.should.equal('route');
3938
res.end();
4039
});

test/app.use.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,14 @@ describe('app', function(){
6969
, app = express();
7070

7171
blog.get('/', function(req, res){
72-
res.end(req.params.article);
72+
res.end('success');
7373
});
7474

7575
app.use('/post/:article', blog);
7676

7777
request(app)
7878
.get('/post/once-upon-a-time')
79-
.expect('once-upon-a-time', done);
79+
.expect('success', done);
8080
})
8181
})
8282
})

0 commit comments

Comments
 (0)