Skip to content

Commit

Permalink
feat: upgrade to serve-static@0.16.0
Browse files Browse the repository at this point in the history
  • Loading branch information
UlisesGascon committed Sep 10, 2024
1 parent 9ebe5d5 commit 4c9ddc1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions History.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
unreleased
==========
* deps: serve-static@0.16.0
* Remove link renderization in html while redirecting
* deps: send@0.19.0
* Remove link renderization in html while redirecting
* deps: body-parser@0.6.0
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"range-parser": "~1.2.1",
"safe-buffer": "5.2.1",
"send": "0.19.0",
"serve-static": "1.15.0",
"serve-static": "1.16.0",
"setprototypeof": "1.2.0",
"statuses": "2.0.1",
"type-is": "~1.6.18",
Expand Down
4 changes: 2 additions & 2 deletions test/express.static.js
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ describe('express.static()', function () {
request(this.app)
.get('/users')
.expect('Location', '/users/')
.expect(301, /<a href="\/users\/">/, done)
.expect(301, /\/users\//, done)
})

it('should redirect directories with query string', function (done) {
Expand All @@ -508,7 +508,7 @@ describe('express.static()', function () {
.get('/snow')
.expect('Location', '/snow%20%E2%98%83/')
.expect('Content-Type', /html/)
.expect(301, />Redirecting to <a href="\/snow%20%E2%98%83\/">\/snow%20%E2%98%83\/<\/a></, done)
.expect(301, />Redirecting to \/snow%20%E2%98%83\/</, done)
})

it('should respond with default Content-Security-Policy', function (done) {
Expand Down

2 comments on commit 4c9ddc1

@NewEraCracker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also bump send within "serve-static": "1.16.0", .

express requires "send": "0.19.0", but "serve-static": "1.16.0", requires "send": "0.18.0",

@wesleytodd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NewEraCracker can you open these as issues? making comments on commits will just get lost.

Please sign in to comment.