Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to the Collaborator Guide #45

Closed
hacksparrow opened this issue Nov 18, 2016 · 2 comments
Closed

Add more details to the Collaborator Guide #45

hacksparrow opened this issue Nov 18, 2016 · 2 comments

Comments

@hacksparrow
Copy link
Member

As suggested by @dougwilson on Express TC meeting 11-16-2016, we should add more details to the existing Collaborator Guide, focussed around code and other convention that must be followed when opening a PR.

This will help to focus PR discussions on implementations rather than on the conventions that should have been followed.

@crandmck
Copy link
Member

Note that we also have https://github.com/expressjs/express/blob/master/Contributing.md. The distinction between these two is not immediately apparent to me...

Also, the content of these two files is duplicated in http://expressjs.com/en/resources/contributing.html.
I opened expressjs/expressjs.com#734 so we can just "pull down" the content of these files, rather than duplicating them. Then, we we update the md files in the express repo, when we run the script, they'll get updated in the docs as well.

@crandmck
Copy link
Member

Issue moved to expressjs/expressjs.com #765 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants