Refactor JSONCookies function for improved readability and modern syntax#119
Open
Ayoub-Mabrouk wants to merge 1 commit intoexpressjs:masterfrom
Open
Refactor JSONCookies function for improved readability and modern syntax#119Ayoub-Mabrouk wants to merge 1 commit intoexpressjs:masterfrom
Ayoub-Mabrouk wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Ayoub-Mabrouk
commented
Nov 1, 2024
Ayoub-Mabrouk
commented
- Replaced Object.keys() with Object.entries() for cleaner iteration over key-value pairs.
- Utilized destructuring in the loop to enhance code clarity.
- Improved variable naming for better understanding of the decoded value.
- Maintained functionality of decoding JSON cookies while updating the original object.
- Replaced Object.keys() with Object.entries() for cleaner iteration over key-value pairs. - Utilized destructuring in the loop to enhance code clarity. - Improved variable naming for better understanding of the decoded value. - Maintained functionality of decoding JSON cookies while updating the original object.
Member
|
We don't have support for ES syntax yet as we support Node@0.8 https://github.com/expressjs/cookie-parser/actions/runs/11623042363/job/32384208780?pr=119 |
This was referenced Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.