Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt/1157 #11

Open
richardlehane opened this issue Sep 19, 2018 · 10 comments
Open

fmt/1157 #11

richardlehane opened this issue Sep 19, 2018 · 10 comments

Comments

@richardlehane
Copy link

The new Folio Infobase File has overlapping beginning-of-file sequences:

image

Only the "Folio" bit is being generated in the test signature.

@ross-spencer
Copy link
Member

Is this an error with PRONOM do you think @richardlehane?

@richardlehane
Copy link
Author

it is a bit of an odd one, but I think intended: i.e. looks for two sequences "Folio" and "v200" which both need to be near the start of the file but can be in any order

@jcharlet
Copy link

confirmed with@Dclipsham . Failed testing DROID on this file

No results found for file: fmt-1157-signature-id-1539.nfo. Expected: fmt/1157

fmt/1157 skeleton suite hasn't created a conformant file - https://www.nationalarchives.gov.uk/PRONOM/Format/proFormatSearch.aspx?status=detailReport&id=1967&strPageToDisplay=signatures

file should contain string' v200' which equates to 0x76323030 but this is missing from the file available via zenodo for v95 https://zenodo.org/record/3269467#.Xc1KGDP7SUk

@ross-spencer
Copy link
Member

Thanks Jeremie, et al. I should have done something with this but forgot about it... Not sure I'll have a fix for a few weeks, but let me know if it does help you to have it sooner or if you can live without for this release.

@Dclipsham
Copy link

Thanks Ross, it just came up as part of DROID testing. I've created a pair of files that contain the missing 'v200' so a fix certainly isn't urgent from our perspective (am happy to share these - GitHub Issues doesn't like the file type though for file upload - let me know if you want them..). As Richard points out we cant be certain of the order in which 'Folio' and 'v200' will appear so expressed them both as distinct BOFs with offset range set

@ross-spencer
Copy link
Member

Sounds good, if you zip them, the can be added here, and I can use them for reference in the fix!

I have of course excitedly being watching references to the suite in recent testing. Big changes. They look to be shaping up well.

@Dclipsham
Copy link

Great - learning something new :) thank you!
fmt-1157-variants.zip

@richardlehane
Copy link
Author

richardlehane commented Sep 11, 2022

the latest release (v108) has a couple more signatures impacted by this: fmt/1739 and 1757

@ross-spencer
Copy link
Member

Wondering if I fixed this for container signatures and whether this will work here: exponential-decay/skeleton-container-test-suite-generator#14

@richardlehane
Copy link
Author

@richardlehane richardlehane mentioned this issue Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants