Skip to content

fix: remove . as a split condition in noise_sensitivity.py #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jiajunly
Copy link
Contributor

@jiajunly jiajunly commented Nov 5, 2024

Fix #1626 to support more languages.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 5, 2024
@shahules786 shahules786 self-requested a review November 5, 2024 12:31
@jiajunly jiajunly requested a review from shahules786 November 7, 2024 03:38
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you:)

@shahules786 shahules786 merged commit 5f74eb5 into explodinggradients:main Nov 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In NoiseSensitivity, the . should be deleted as the split condition.
2 participants