Skip to content

Commit 44e2409

Browse files
Change the validate_samples functionality (#1879)
Changed the validate_samples functionality to also tell which indexed sample is causing the issue. #1875 Co-authored-by: Vidit Ostwal <vidit.ostwal@piramal.com>
1 parent d1dd619 commit 44e2409

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/ragas/dataset_schema.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,10 @@ def validate_samples(self, samples: t.List[Sample]) -> t.List[Sample]:
188188
if len(samples) == 0:
189189
return samples
190190

191-
first_sample_type = type(self.samples[0])
192-
if not all(isinstance(sample, first_sample_type) for sample in self.samples):
193-
raise ValueError("All samples must be of the same type")
191+
first_sample_type = type(samples[0])
192+
for i, sample in enumerate(samples):
193+
if not isinstance(sample, first_sample_type):
194+
raise ValueError(f"Sample at index {i} is of type {type(sample)}, expected {first_sample_type}")
194195

195196
return samples
196197

0 commit comments

Comments
 (0)