From d68d8044618ea5a0ede3ecf6f0b495b672a05e8c Mon Sep 17 00:00:00 2001 From: Matthew Kobs Date: Tue, 9 Apr 2019 10:53:38 -0500 Subject: [PATCH] Recognize Building notice as not an error --- lib/ember_cli/build_monitor.rb | 7 ++++++- spec/lib/ember_cli/build_monitor_spec.rb | 13 +++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/ember_cli/build_monitor.rb b/lib/ember_cli/build_monitor.rb index 9a464901..75cbf448 100644 --- a/lib/ember_cli/build_monitor.rb +++ b/lib/ember_cli/build_monitor.rb @@ -42,7 +42,8 @@ def error_file_exists? def build_errors error_lines. reject { |line| is_blank_or_backtrace?(line) }. - reject { |line| is_deprecation_warning?(line) } + reject { |line| is_deprecation_warning?(line) }. + reject { |line| is_building_notice?(line) } end def has_build_errors? @@ -57,6 +58,10 @@ def is_deprecation_warning?(line) line =~ /^(\e[^\s]+)?DEPRECATION:/ end + def is_building_notice?(line) + line =~ /^(\e[^\s]+)?.\s(\e[^\s]+)?Building/ + end + def error_lines if error_file_exists? error_file.readlines diff --git a/spec/lib/ember_cli/build_monitor_spec.rb b/spec/lib/ember_cli/build_monitor_spec.rb index 5a47c173..a9338434 100644 --- a/spec/lib/ember_cli/build_monitor_spec.rb +++ b/spec/lib/ember_cli/build_monitor_spec.rb @@ -86,6 +86,19 @@ end end + context "when the error file contains an ASCII colored Building notice" do + it "does not raise a BuildError" do + error_file = error_file_with_contents( + [ + "- \e[32mBuilding\e[39m" + ]) + paths = build_paths(error_file) + monitor = EmberCli::BuildMonitor.new(nil, paths) + + expect(monitor.check!).to be true + end + end + context "when the error file contains both errors & deprecation warnings" do it "raises a BuildError" do error_file = error_file_with_contents(