Skip to content

Commit 753d7af

Browse files
committed
Make updates based on review by @kotp at tommyschaefer#1
1 parent 9aaa8a1 commit 753d7af

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

lib/wordy_cases.rb

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
class WordyCase < OpenStruct
22
def test_name
3-
'test_%s' % description.downcase.tr_s(' ', '_')
3+
'test_%s' % description.downcase.tr(' ', '_')
44
end
55

66
def workload
@@ -17,9 +17,7 @@ def skipped
1717
private
1818

1919
def indent(size, lines)
20-
lines.split("\n").map do |line|
21-
' ' * size + line
22-
end.join("\n")
20+
lines.lines.each_with_object('') { |line, obj| obj << ' ' * size + line }
2321
end
2422

2523
def assertion
@@ -48,13 +46,13 @@ def message_assertion
4846

4947
class WordyCase::PreProcessor
5048
class << self
51-
def call(row:)
52-
row.merge('message' => message_for(row: row))
49+
def call(row)
50+
row.merge('message' => message_for(row))
5351
end
5452

5553
private
5654

57-
def message_for(row:)
55+
def message_for(row)
5856
return unless row['input'] == 'What is -3 plus 7 multiplied by -2?'
5957

6058
'You should ignore order of precedence. -3 + 7 * -2 = -8, not %s'
@@ -64,6 +62,6 @@ def message_for(row:)
6462

6563
WordyCases = proc do |data|
6664
JSON.parse(data)['cases'].map.with_index do |row, i|
67-
WordyCase.new(WordyCase::PreProcessor.call(row: row).merge(index: i))
65+
WordyCase.new(WordyCase::PreProcessor.call(row).merge(index: i))
6866
end
6967
end

test/wordy_cases_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ def test_workload_without_expected
6666
class WordyCasePrProcessorTest < Minitest::Test
6767
def test_call_as_non_special_case
6868
row = { 'input' => '' }
69-
processed_row = WordyCase::PreProcessor.call(row: row)
69+
processed_row = WordyCase::PreProcessor.call(row)
7070

7171
assert_equal({ 'input' => '', 'message' => nil }, processed_row)
7272
end
7373

7474
def test_call_as_special_case
7575
row = { 'input' => 'What is -3 plus 7 multiplied by -2?' }
76-
processed_row = WordyCase::PreProcessor.call(row: row)
76+
processed_row = WordyCase::PreProcessor.call(row)
7777
expected_row = {
7878
'input' => 'What is -3 plus 7 multiplied by -2?',
7979
'message' => 'You should ignore order of precedence. -3 + 7 * -2 = -8, not %s',

0 commit comments

Comments
 (0)