triangle: adding a new scalene test for two smaller sides equal#1894
Merged
Conversation
Adding a new test for scalene(sides) function and renaming another test to match the new test.
New merge
cmccandless
suggested changes
Aug 7, 2019
cmccandless
left a comment
Contributor
There was a problem hiding this comment.
Hi! Thanks for the PR!
Most test cases in the Python track are derived from the problem-specifications repository. You've identified a gap in the tests, so normally I would recommend adding the test to the canonical data first before it is added here. However, since that repository is currently frozen, we can add this test as a track-specific test for now.
Please address the following, and we'll be good to go:
- Revert name change on the existing test; the name comes from the canonical data, and we try to follow that when reasonable
- Rename your new test to something descriptive of why that test is different than
two_sides_are_equal. I've suggested a change below; if you have something better you don't need to use my suggestion exactly
I would also recommend creating an issue in the [problem specifications] repository so that when the freeze is over, this test can be added there.
add track-specific test Co-Authored-By: Corey McCandless <cmccandless@users.noreply.github.com>
Co-Authored-By: Corey McCandless <cmccandless@users.noreply.github.com>
cmccandless
approved these changes
Aug 7, 2019
Contributor
|
Merged; thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new test for scalene(sides) function and renaming another test to match the new test. Current tests for scalene(sides) function can be hacked by this code:
while the new test not.