Skip to content

two-bucket: Make exercise schema-compliant #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2017
Merged

two-bucket: Make exercise schema-compliant #713

merged 3 commits into from
Mar 12, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Mar 12, 2017

Related to #625.

rbasso added 3 commits March 12, 2017 15:26
These are not the most creative descriptions, but they are needed
for compliant with the new JSON schema.
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my sympathies about those descriptions.

I don't have much help here. If it helps, here are the states on each path:

3/3, 0/5, goal 1
move 1: 3/3, 0/5
move 2: 0/3, 3/5
move 3: 3/3, 3/5
move 4: 1/3, 5/5

5/5, 0/3, goal 1
move 1: 5/5, 0/3
move 2: 2/5, 3/3
move 3: 2/5, 0/3
move 4: 0/5, 2/3
move 5: 5/5, 2/3
move 6: 4/5, 3/3
move 7: 4/5, 0/3
move 8: 1/5, 3/3

7/7, 0/11, goal 2
move 1: 7/7, 0/11
move 2: 0/7, 7/11
move 3: 7/7, 7/11
move 4: 3/7, 11/11
move 5: 3/7, 0/11
move 6: 0/7, 3/11
move 7: 7/7, 3/11
move 8: 0/7, 10/11
move 9: 7/7, 10/11
move 10: 6/7, 11/11
move 11: 6/7, 0/11
move 12: 0/7, 6/11
move 13: 7/7, 6/11
move 14: 2/7, 11/11

11/11, 0/7, goal 2
move 1: 11/11, 0/7
move 2: 4/11, 7/7
move 3: 4/11, 0/7
move 4: 0/11, 4/7
move 5: 11/11, 4/7
move 6: 8/11, 7/7
move 7: 8/11, 0/7
move 8: 1/11, 7/7
move 9: 1/11, 0/7
move 10: 0/11, 1/7
move 11: 11/11, 1/7
move 12: 5/11, 7/7
move 13: 5/11, 0/7
move 14: 0/11, 5/7
move 15: 11/11, 5/7
move 16: 9/11, 7/7
move 17: 9/11, 0/7
move 18: 2/11, 7/7

@petertseng
Copy link
Member

Remarks:

3/3, 0/5, goal 1: Only requires the "fill first" and "first -> second" actions.
5/5, 0/3, goal 1: Requires all three actions.
7/7, 0/11, goal 2: I can't tell you what this tests that the above two don't (because the second case already covers all three actions), other than "different bucket sizes"
11/11, 0/7, goal 2: Same.

@rbasso rbasso merged commit 2a655f7 into exercism:master Mar 12, 2017
@rbasso rbasso deleted the two-bucket-schema branch March 12, 2017 08:56
@petertseng
Copy link
Member

And this just made me realize: Unless the goal amount is exactly one bucket's capacity, by necessity the other bucket will be full when the goal is reached.

@rbasso
Copy link
Contributor Author

rbasso commented Mar 12, 2017

Sorry, @petertseng . I saw the approved and almost immediately merged. Shall I revert?

@petertseng
Copy link
Member

Shall I revert?

No real reason to. The only thing that will come out of my comments is maybe it will help you find a better description (but it didn't help me). If it helps you, just update the descriptions.

}
}
]
"exercise": "two-buckets",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the singular two-bucket perhaps? rather than the plural two-buckets

unless it doesn't need to match the exercise slug

maybe that should be checked, I certainly don't have anything that checks it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I screwed it! It should be two-bucket.

Thanks for catching that (my third big mistake in 24 hour). 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also bump the version number to 1.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emcoding pushed a commit that referenced this pull request Nov 19, 2018
All Your Base: Update test case ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants