-
-
Notifications
You must be signed in to change notification settings - Fork 554
two-bucket: Make exercise schema-compliant #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are not the most creative descriptions, but they are needed for compliant with the new JSON schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my sympathies about those descriptions.
I don't have much help here. If it helps, here are the states on each path:
3/3, 0/5, goal 1
move 1: 3/3, 0/5
move 2: 0/3, 3/5
move 3: 3/3, 3/5
move 4: 1/3, 5/5
5/5, 0/3, goal 1
move 1: 5/5, 0/3
move 2: 2/5, 3/3
move 3: 2/5, 0/3
move 4: 0/5, 2/3
move 5: 5/5, 2/3
move 6: 4/5, 3/3
move 7: 4/5, 0/3
move 8: 1/5, 3/3
7/7, 0/11, goal 2
move 1: 7/7, 0/11
move 2: 0/7, 7/11
move 3: 7/7, 7/11
move 4: 3/7, 11/11
move 5: 3/7, 0/11
move 6: 0/7, 3/11
move 7: 7/7, 3/11
move 8: 0/7, 10/11
move 9: 7/7, 10/11
move 10: 6/7, 11/11
move 11: 6/7, 0/11
move 12: 0/7, 6/11
move 13: 7/7, 6/11
move 14: 2/7, 11/11
11/11, 0/7, goal 2
move 1: 11/11, 0/7
move 2: 4/11, 7/7
move 3: 4/11, 0/7
move 4: 0/11, 4/7
move 5: 11/11, 4/7
move 6: 8/11, 7/7
move 7: 8/11, 0/7
move 8: 1/11, 7/7
move 9: 1/11, 0/7
move 10: 0/11, 1/7
move 11: 11/11, 1/7
move 12: 5/11, 7/7
move 13: 5/11, 0/7
move 14: 0/11, 5/7
move 15: 11/11, 5/7
move 16: 9/11, 7/7
move 17: 9/11, 0/7
move 18: 2/11, 7/7
Remarks: 3/3, 0/5, goal 1: Only requires the "fill first" and "first -> second" actions. |
And this just made me realize: Unless the goal amount is exactly one bucket's capacity, by necessity the other bucket will be full when the goal is reached. |
Sorry, @petertseng . I saw the approved and almost immediately merged. Shall I revert? |
No real reason to. The only thing that will come out of my comments is maybe it will help you find a better description (but it didn't help me). If it helps you, just update the descriptions. |
} | ||
} | ||
] | ||
"exercise": "two-buckets", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the singular two-bucket perhaps? rather than the plural two-buckets
unless it doesn't need to match the exercise slug
maybe that should be checked, I certainly don't have anything that checks it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I screwed it! It should be two-bucket
.
Thanks for catching that (my third big mistake in 24 hour). 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also bump the version number to 1.0.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Your Base: Update test case ordering
Related to #625.