Skip to content

luhn: non-digit at end is invalid #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2018
Merged

luhn: non-digit at end is invalid #1420

merged 1 commit into from
Dec 22, 2018

Conversation

bitfield
Copy link
Contributor

From luhn: add test case with non-digit at the end:

Problem: I had a student only include the digits before the first invalid character. There was no test that failed his solution.

Solution: Added a test that should return false but does not if the student takes only the numbers up to first non-digit.

@bitfield bitfield mentioned this pull request Dec 22, 2018
Merged
@rpottsoh
Copy link
Member

Let me know if you need me to merge.

@bitfield bitfield merged commit d9b62c9 into exercism:master Dec 22, 2018
@bitfield bitfield deleted the luhn/non-digit branch December 22, 2018 19:01
@rpottsoh rpottsoh mentioned this pull request Dec 23, 2018
Merged
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 12, 2019
@ZapAnton
Updated the 'luhn' exercise to the version 1.6.1
0095be1 
Relevant PRs:
- exercism/problem-specifications#1420
- exercism/problem-specifications#1480
- exercism/problem-specifications#1500
- exercism/problem-specifications#1523
@ZapAnton ZapAnton mentioned this pull request Nov 12, 2019
Merged
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 12, 2019
@ZapAnton
luhn: Updated the exercise to the version 1.6.1
ae78e36 
Relevant PRs:
- exercism/problem-specifications#1420
- exercism/problem-specifications#1480
- exercism/problem-specifications#1500
- exercism/problem-specifications#1523
coriolinus pushed a commit to exercism/rust that referenced this pull request Nov 15, 2019
@ZapAnton @coriolinus
luhn: Updated the exercise to the version 1.6.1 (#906)
39ef37d 
* luhn: Updated the exercise to the version 1.6.1

Relevant PRs:
- exercism/problem-specifications#1420
- exercism/problem-specifications#1480
- exercism/problem-specifications#1500
- exercism/problem-specifications#1523

* luhn: Fixed the 'exercise' util generated comments in the test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpottsoh rpottsoh rpottsoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitfield @rpottsoh