Skip to content

Commit 6fd8e2d

Browse files
committed
use exercise_name for example solution in rake tasks
1 parent 76107ac commit 6fd8e2d

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

lib/tasks/exercise.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,32 +11,32 @@ def slugs
1111
end
1212
end
1313

14-
attr_reader :name
15-
alias :to_s :name
14+
attr_reader :slug
15+
alias :to_s :slug
1616

17-
def initialize(name)
18-
@name = name
17+
def initialize(slug)
18+
@slug = slug
1919
end
2020

2121
def directory
22-
"exercises/#{name}/."
22+
"exercises/#{slug}/."
2323
end
2424

2525
def example_file
26-
File.join('.meta', 'solutions', "#{name}.rb")
26+
File.join('.meta', 'solutions', "#{exercise_name}.rb")
2727
end
2828

2929
def testable_example_file
30-
"#{base_file_name}.rb"
30+
"#{exercise_name}.rb"
3131
end
3232

3333
def test_file
34-
"#{base_file_name}_test.rb"
34+
"#{exercise_name}_test.rb"
3535
end
3636

3737
private
3838

39-
def base_file_name
40-
@_base_file_name ||= name.tr('-', '_')
39+
def exercise_name
40+
@exercise_name ||= slug.tr('-', '_')
4141
end
4242
end

lib/tasks/exercise_tests_runner.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def initialize(exercise:, test_options: '')
1212
def run
1313
puts "\n\n#{'-' * 64}\nrunning tests for: #{@exercise}"
1414

15-
Dir.mktmpdir(@exercise.name) do |dir|
15+
Dir.mktmpdir(@exercise.slug) do |dir|
1616
setup_exercise_files_in(dir)
1717
run_exercise_tests_in(dir)
1818
end

test/tasks/exercise_test.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,19 @@ def test_all
1010

1111
FileList.stub :[], FileList["#{dir}/*"] do
1212
assert_equal true, Exercise.all.all? { |e| e.instance_of?(Exercise) }
13-
assert_equal ['test', 'test2'], Exercise.all.map(&:name)
13+
assert_equal ['test', 'test2'], Exercise.all.map(&:slug)
1414
end
1515
end
1616
end
1717

18-
def test_name
19-
exercise = Exercise.new('name')
20-
assert_equal 'name', exercise.name
18+
def test_slug
19+
exercise = Exercise.new('slug')
20+
assert_equal 'slug', exercise.slug
2121
end
2222

2323
def test_to_s
24-
exercise = Exercise.new('name')
25-
assert_equal 'name', exercise.to_s
24+
exercise = Exercise.new('slug')
25+
assert_equal 'slug', exercise.to_s
2626
end
2727

2828
def test_directory

test/tasks/exercise_tests_runner_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
require_relative '../test_helper'
22

33
class FakeExercise
4-
def name
4+
def slug
55
'test'
66
end
77

8-
alias :to_s :name
8+
alias :to_s :slug
99

1010
def directory
1111
'test/.'

0 commit comments

Comments
 (0)