Skip to content

✨ Add new exercise : Affine Cipher #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 3, 2020
Merged

✨ Add new exercise : Affine Cipher #887

merged 7 commits into from
Nov 3, 2020

Conversation

TomPradat
Copy link
Contributor

Fix #886

TomPradat
TomPradat commented Oct 29, 2020
View reviewed changes
TomPradat
TomPradat commented Oct 29, 2020
View reviewed changes
@SleeplessByte SleeplessByte added the hacktoberfest-accepted Opt-in to hacktoberfest label Oct 30, 2020
@SleeplessByte SleeplessByte self-requested a review October 30, 2020 21:22
@TomPradat TomPradat changed the title WIP ✨ Add new exercise : Affine Cipher ✨ Add new exercise : Affine Cipher Oct 30, 2020
SleeplessByte
SleeplessByte reviewed Nov 2, 2020
View reviewed changes
config.json Outdated
@@ -1464,6 +1464,19 @@
"topics": [
"graph_theory"
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is ordered. Or at least it was. It should be around the other unlocked_by simple-cipher, and then it's probably sorted by difficulty > lexographically.

SleeplessByte
SleeplessByte approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits :). Looking great @TomPradat

exercises/affine-cipher/affine-cipher.js Outdated

export const decode = (phrase, key) => {
throw new Error("Remove this statement and implement this function");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
};

exercises/affine-cipher/example.js Outdated
@@ -0,0 +1,101 @@
const ALPHABET = 'abcdefghijklmnopqrstuvwxyz';
const m = ALPHABET.length;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uppercase this, and give it a name?

@SleeplessByte SleeplessByte merged commit e7bda13 into exercism:master Nov 3, 2020
@SleeplessByte
Copy link
Member

You're on a roll! Are you on our maintainers list yet? Would you like to help out with v3?

@TomPradat
Copy link
Contributor Author

You're on a roll! Are you on our maintainers list yet? Would you like to help out with v3?

Idk if I'm on the maintainers list yet, i guess not. I've already started a PR to help with v3 and I'll be glad to help more 👍

This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte Awaiting requested review from SleeplessByte

Assignees
No one assigned
Labels
hacktoberfest-accepted Opt-in to hacktoberfest new exercise ✨ x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new exercise : Affine cipher
3 participants
@TomPradat @SleeplessByte @ErikSchierboom