Get ESLint rolling #479
Merged
Get ESLint rolling #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which eventually is run by travis. Along with an eslintignore file for all exercises. We will fix and enable eslint for each exercise.
eslint `jsx` and `react` packages are not required.
Since this is a plain JS repo (no react/JSX) - base is what we need.
To avoid fatal error on no files found: https://eslint.org/docs/5.0.0/user-guide/migrating-to-5.0.0#nonexistent-files In the process also change `hello-world` to not use `class`.
|
Thanks @tejasbubane! Welcome and overdue updates... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the ball rolling with eslint 🎱
Changes in the PR:
default-exportrule and eslint and prefernamed-exportinstead.eslintignorefile with all exercise directories. Plan is to remove each line from there while fixing eslint for that exercise.airbnb-baseinstead of completeairbnb. Since this is a plain JS repo (no react/JSX) - base is what we need.hello-worldexercise (and in the process change it to not use class).