Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multiply and divide methods accepting double from ComplexNumber #2851

Closed
wants to merge 1 commit into from
+5 −19
Closed

Remove multiply and divide methods accepting double from ComplexNumber #2851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions exercises/practice/complex-numbers/.meta/src/reference/java/ComplexNumber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
final class ComplexNumber {

private final double real;

private final double imaginary;

ComplexNumber(double real, double imaginary) {
Expand Down Expand Up @@ -32,7 +31,10 @@ ComplexNumber subtract(ComplexNumber other) {
}

ComplexNumber divide(ComplexNumber other) {
return this.multiply(other.conjugate()).divide(Math.pow(other.abs(), 2));
double divisor = Math.pow(other.real, 2) + Math.pow(other.imaginary, 2);
return new ComplexNumber(
(real * other.real + imaginary * other.imaginary) / divisor,
(real * other.imaginary - imaginary * other.real) / divisor);
}

double abs() {
Expand All @@ -46,12 +48,4 @@ ComplexNumber conjugate() {
ComplexNumber exponentialOf() {
return new ComplexNumber(Math.cos(imaginary), Math.sin(imaginary)).multiply(Math.exp(real));
}

private ComplexNumber divide(double factor) {
return new ComplexNumber(real / factor, imaginary / factor);
}

private ComplexNumber multiply(double factor) {
return new ComplexNumber(factor * real, factor * imaginary);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a compile error because this method is still being used on line 49 (see the Lint output).

}
}
}
8 changes: 0 additions & 8 deletions exercises/practice/complex-numbers/src/main/java/ComplexNumber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,10 @@ ComplexNumber multiply(ComplexNumber other) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber multiply(double factor) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber divide(ComplexNumber other) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber divide(double divisor) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber conjugate() {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}
Expand Down
Loading